From: Simon Horman <simon.horman@netronome•com>
To: Jakub Kicinski <kubakici@wp•pl>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
David Miller <davem@davemloft•net>,
benjamin.lahaise@netronome•com, netdev@vger•kernel.org,
bcrl@kvack•org, Jiri Pirko <jiri@resnulli•us>
Subject: Re: [PATCH net-next 0/2] flower: add MPLS matching support
Date: Tue, 25 Apr 2017 13:55:00 +0200 [thread overview]
Message-ID: <20170425115459.GA23939@vergenet.net> (raw)
In-Reply-To: <20170424190743.4ad24ad1@cakuba.netronome.com>
On Mon, Apr 24, 2017 at 07:07:43PM -0700, Jakub Kicinski wrote:
> On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote:
> > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote:
> > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote:
> >
> > >
> > > Hrm. maybe I am wrong.
> > > Lets say user sets all of the 8 bits in BOS,
> > > what does setting
> > > key_val->mpls_bos = nla_get_u8 do?
> > >
> > > Same with the 20 bits for the label in the u32
> > > or 3 bit bits in the u8 tc.
> >
> > The label and tc are masked - maybe just the BOS
> > needs something similar?
>
> Indeed, good catch!
I agree something should be done wrt BOS. If the LABEL and TC are to
be left as-is then I think a similar treatment of BOS - that is masking it
- makes sense.
I also agree with statements made earlier in the thread that it is unlikely
that the unused bits of these attributes will be used - as opposed to a
bitmask of flag values which seems ripe for re-use for future flags.
I would like to add to the discussion that I think in future it would
be good to expand the features provided by this patch to support supplying
a mask as part of the match - as flower supports for other fields such
as IP addresses. But I think the current scheme of masking out invalid bits
should also work in conjunction with user-supplied masks.
next prev parent reply other threads:[~2017-04-25 11:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 20:52 [PATCH net-next 0/2] flower: add MPLS matching support Benjamin LaHaise
2017-04-22 20:52 ` [PATCH net-next 1/2] flow_dissector: add mpls support (v2) Benjamin LaHaise
2017-04-24 7:05 ` Jiri Pirko
2017-04-22 20:52 ` [PATCH net-next 2/2] cls_flower: add support for matching MPLS fields (v2) Benjamin LaHaise
2017-04-24 7:07 ` Jiri Pirko
2017-04-24 18:32 ` [PATCH net-next 0/2] flower: add MPLS matching support David Miller
2017-04-25 0:58 ` Jamal Hadi Salim
2017-04-25 1:05 ` Benjamin LaHaise
2017-04-25 1:25 ` Jamal Hadi Salim
2017-04-25 1:20 ` Jakub Kicinski
2017-04-25 1:48 ` Jamal Hadi Salim
2017-04-25 2:00 ` Jamal Hadi Salim
2017-04-25 2:06 ` Jamal Hadi Salim
2017-04-25 2:07 ` Jakub Kicinski
2017-04-25 11:55 ` Simon Horman [this message]
2017-04-25 12:47 ` Jamal Hadi Salim
2017-04-25 17:26 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425115459.GA23939@vergenet.net \
--to=simon.horman@netronome$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=benjamin.lahaise@netronome$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kubakici@wp$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox