From: Steffen Klassert <steffen.klassert@secunet•com>
To: Xin Long <lucien.xin@gmail•com>
Cc: network dev <netdev@vger•kernel.org>, <davem@davemloft•net>,
Herbert Xu <herbert@gondor•apana.org.au>, <fw@strlen•de>
Subject: Re: [PATCH net] xfrm: do the garbage collection after flushing policy
Date: Thu, 27 Apr 2017 09:27:13 +0200 [thread overview]
Message-ID: <20170427072713.GW2649@secunet.com> (raw)
In-Reply-To: <b55e4ad516bc1be8fe70f68de028a4b32055e43f.1493019219.git.lucien.xin@gmail.com>
On Mon, Apr 24, 2017 at 03:33:39PM +0800, Xin Long wrote:
> Now xfrm garbage collection can be triggered by 'ip xfrm policy del'.
> These is no reason not to do it after flushing policies, especially
> considering that 'garbage collection deferred' is only triggered
> when it reaches gc_thresh.
>
> It's no good that the policy is gone but the xdst still hold there.
> The worse thing is that xdst->route/orig_dst is also hold and can
> not be released even if the orig_dst is already expired.
>
> This patch is to do the garbage collection if there is any policy
> removed in xfrm_policy_flush.
>
> Signed-off-by: Xin Long <lucien.xin@gmail•com>
Applied to the ipsec tree, thanks!
prev parent reply other threads:[~2017-04-27 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 7:33 [PATCH net] xfrm: do the garbage collection after flushing policy Xin Long
2017-04-27 7:27 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427072713.GW2649@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fw@strlen$(echo .)de \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox