Subject: Re: [PATCH net-next iproute2] ip: increase number of MPLS labels

From: Stephen Hemminger <[email-masked]>
Date: Mon, 1 May 2017 09:15:40 -0700

On Sun, 30 Apr 2017 17:42:15 -0600
David Ahern <[email-masked]> wrote:

> On 4/30/17 12:04 AM, Stephen Hemminger wrote:
> > On Sat, 29 Apr 2017 20:48:50 -0700
> > David Ahern <[email-masked]> wrote:
> >   
> >> Kernel now supports more than 2 labels. Increase ip to
> >> handle up to 16 labels.
> >>
> >> Signed-off-by: David Ahern <[email-masked]>
> >> ---
> >>  include/utils.h | 8 ++++----
> >>  lib/utils.c     | 2 +-
> >>  2 files changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/include/utils.h b/include/utils.h
> >> index 8c12e1e2a60c..a69e176c260d 100644
> >> --- a/include/utils.h
> >> +++ b/include/utils.h
> >> @@ -54,6 +54,9 @@ void incomplete_command(void) __attribute__((noreturn));
> >>  #define NEXT_ARG_FWD() do { argv++; argc--; } while(0)
> >>  #define PREV_ARG() do { argv--; argc++; } while(0)
> >>  
> >> +/* Maximum number of labels the mpls helpers support */
> >> +#define MPLS_MAX_LABELS 16
> >> +  
> > 
> > Why is the kernel limit not in include/uapi/ header file?
> >   
> 
> I believe Eric had reasons, but not sure why.

I just don't want iproute2 utilities chasing kernel values.
Would prefer either make utilities take any size, or inherit maximum from kernel headers.