Subject: Re: [PATCH net-next iproute2 1/3] netlink: import netlink message parsing from kernel

From: Stephen Hemminger <[email-masked]>
Date: Tue, 2 May 2017 11:03:14 -0700

On Tue, 02 May 2017 13:00:32 -0400 (EDT)
David Miller <[email-masked]> wrote:

> From: David Ahern <[email-masked]>
> Date: Tue, 2 May 2017 10:51:23 -0600
> 
> > On 5/2/17 9:25 AM, Stephen Hemminger wrote:  
> >> Please either use existing netlink attribute code in libnetlink.h
> >> (rta_getattr_u32 etc) or use libmnl like devlink.  
> > 
> > All of the existing rta_ functions take a struct rta_attr; netlink
> > messages use struct nlattr. It's just wrong to use rta functions for
> > netlink messages.  
> 
> Agreed.
> 
> > There is no existing parse function for nlattr. There is no existing
> > validate function - for nlattr or rta_attr. So I do not see any overlap
> > with existing code.  
> 
> Also agreed.

Then use libmnl it is already used in several other places in iproute2.
Eventually, I would like to use it everywhere and get rid of old netlink parser.