Subject: Re: [RFC PATCH v2 07/17] net: sched: drop qdisc_reset from dev_graft_qdisc

From: Jesper Dangaard Brouer <[email-masked]>
Date: Tue, 2 May 2017 22:00:53 +0200

On Tue, 02 May 2017 08:38:19 -0700
John Fastabend <[email-masked]> wrote:

> @@ -991,20 +996,25 @@ void dev_deactivate_many(struct list_head *head)
>  					     &noop_qdisc);
>  
>  		dev_watchdog_down(dev);
> -		sync_needed |= !dev->dismantle;
>  	}
>  
>  	/* Wait for outstanding qdisc-less dev_queue_xmit calls.
>  	 * This is avoided if all devices are in dismantle phase :
>  	 * Caller will call synchronize_net() for us
>  	 */

Is the comment still correct after this change?

> -	if (sync_needed)
> -		synchronize_net();
> +	synchronize_net();

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer