From: "Gustavo A. R. Silva" <garsilva@embeddedor•com>
To: "David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
James Morris <jmorris@namei•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Patrick McHardy <kaber@trash•net>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor•com>,
Joe Perches <joe@perches•com>
Subject: [PATCH] net: ipv4: add code comment for clarification
Date: Thu, 4 May 2017 14:44:16 -0500 [thread overview]
Message-ID: <20170504194415.GA29391@embeddedgus> (raw)
In-Reply-To: <20170504142432.Horde.g9y26Ryxbtg1EIl_cnsdbbw@gator4166.hostgator.com>
Add code comment to make it clear that the position of the arguments
req->id.idiag_dport and req->id.idiag_sport is a locked in behavior
and it should not be changed.
Addresses-Coverity-ID: 1357474
Cc: David Miller <davem@davemloft•net>
Cc: Joe Perches <joe@perches•com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor•com>
---
net/ipv4/inet_diag.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index 3828b3a..841800b 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff *skb,
nlmsg_flags, unlh, net_admin);
}
+/*
+ * Ignore the position of the arguments req->id.idiag_dport and
+ * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup()
+ * functions, once this is a locked in behavior exposed to user space.
+ * Changing this will break things for people.
+ */
struct sock *inet_diag_find_one_icsk(struct net *net,
struct inet_hashinfo *hashinfo,
const struct inet_diag_req_v2 *req)
--
2.5.0
next prev parent reply other threads:[~2017-05-04 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 16:07 [net-ipv4] question about arguments position Gustavo A. R. Silva
2017-05-04 16:46 ` David Miller
2017-05-04 16:56 ` Gustavo A. R. Silva
2017-05-04 17:47 ` Joe Perches
2017-05-04 19:00 ` Gustavo A. R. Silva
2017-05-04 19:02 ` Joe Perches
2017-05-04 19:15 ` Gustavo A. R. Silva
2017-05-04 19:17 ` Joe Perches
2017-05-04 19:24 ` Gustavo A. R. Silva
2017-05-04 19:44 ` Gustavo A. R. Silva [this message]
2017-05-08 15:36 ` [PATCH] net: ipv4: add code comment for clarification David Miller
2017-05-08 15:44 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504194415.GA29391@embeddedgus \
--to=garsilva@embeddedor$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox