From: Steffen Klassert <steffen.klassert@secunet•com>
To: <ilant@mellanox•com>
Cc: David Miller <davem@davemloft•net>,
Boris Pismenny <borisp@mellanox•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net v2 1/1] xfrm: Fix NETDEV_DOWN with IPSec offload
Date: Mon, 8 May 2017 13:50:08 +0200 [thread overview]
Message-ID: <20170508115008.GC9813@secunet.com> (raw)
In-Reply-To: <20170508073934.28529-2-ilant@mellanox.com>
On Mon, May 08, 2017 at 10:39:34AM +0300, ilant@mellanox•com wrote:
> From: Ilan Tayari <ilant@mellanox•com>
>
> Upon NETDEV_DOWN event, all xfrm_state objects which are bound to
> the device are flushed.
>
> The condition for this is wrong, though, testing dev->hw_features
> instead of dev->features. If a device has non-user-modifiable
> NETIF_F_HW_ESP, then its xfrm_state objects are not flushed,
> causing a crash later on after the device is deleted.
>
> Check dev->features instead of dev->hw_features.
>
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Signed-off-by: Ilan Tayari <ilant@mellanox•com>
Applied, thanks Ilan!
prev parent reply other threads:[~2017-05-08 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 7:39 [PATCH net v2 0/1] xfrm: Fix NETDEV_DOWN with IPSec offload ilant
2017-05-08 7:39 ` [PATCH net v2 1/1] " ilant
2017-05-08 11:50 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508115008.GC9813@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=borisp@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ilant@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox