From: Andrew Lunn <andrew@lunn•ch>
To: Christian Lamparter <chunkeey@googlemail•com>
Cc: netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Ivan Mikhaylov <ivan@de•ibm.com>
Subject: Re: [PATCH v2 2/2] net: emac: fix and unify emac_mdio functions
Date: Wed, 7 Jun 2017 16:14:26 +0200 [thread overview]
Message-ID: <20170607141426.GC4874@lunn.ch> (raw)
In-Reply-To: <dc3b77e7ead819001e09589d1f95eb6c1061f381.1496773338.git.chunkeey@googlemail.com>
On Wed, Jun 07, 2017 at 03:51:16PM +0200, Christian Lamparter wrote:
> emac_mdio_read_link() was not copying the requested phy settings
> back into the emac driver's own phy api. This has caused a link
> speed mismatch issue for the AR8035 as the emac driver kept
> trying to connect with 10/100MBps on a 1GBit/s link.
>
> This patch also unifies shared code between emac_setup_aneg()
> and emac_mdio_setup_forced(). And furthermore it removes
> a chunk of emac_mdio_init_phy(), that was copying the same
> data into itself.
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2017-06-07 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 13:51 [PATCH v2 1/2] net: emac: fix reset timeout with AR8035 phy Christian Lamparter
2017-06-07 13:51 ` [PATCH v2 2/2] net: emac: fix and unify emac_mdio functions Christian Lamparter
2017-06-07 14:14 ` Andrew Lunn [this message]
2017-06-08 14:47 ` David Miller
2017-06-07 14:13 ` [PATCH v2 1/2] net: emac: fix reset timeout with AR8035 phy Andrew Lunn
2017-06-08 14:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607141426.GC4874@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=chunkeey@googlemail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ivan@de$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox