Subject: Re: [patch iproute2/net-next] tc: add support for TRAP action

From: Jiri Pirko <[email-masked]>
Date: Thu, 8 Jun 2017 08:57:19 +0200

Mon, Jun 05, 2017 at 04:39:45PM CEST, [email-masked] wrote:
>From: Jiri Pirko <[email-masked]>
>
>Signed-off-by: Jiri Pirko <[email-masked]>

Stephen, note that the kernel part was accepted in v2. Thanks.

>---
> include/linux/pkt_cls.h | 5 +++++
> tc/tc_util.c            | 3 +++
> 2 files changed, 8 insertions(+)
>
>diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h
>index c6e8cf5..477ed05 100644
>--- a/include/linux/pkt_cls.h
>+++ b/include/linux/pkt_cls.h
>@@ -37,6 +37,11 @@ enum {
> #define TC_ACT_QUEUED		5
> #define TC_ACT_REPEAT		6
> #define TC_ACT_REDIRECT		7
>+#define TC_ACT_TRAP		8 /* For hw path, this means "trap to cpu",
>+				   * for sw path, this is equivalent of
>+				   * TC_ACT_STOLEN - drop the skb and act
>+				   * like everything is allright.
>+				   */
> 
> /* There is a special kind of actions called "extended actions",
>  * which need a value parameter. These have a local opcode located in
>diff --git a/tc/tc_util.c b/tc/tc_util.c
>index 4f7283d..5a0f96a 100644
>--- a/tc/tc_util.c
>+++ b/tc/tc_util.c
>@@ -430,6 +430,8 @@ static const char *action_n2a(int action)
> 		return "pipe";
> 	case TC_ACT_STOLEN:
> 		return "stolen";
>+	case TC_ACT_TRAP:
>+		return "trap";
> 	default:
> 		snprintf(buf, 64, "%d", action);
> 		buf[63] = '\0';
>@@ -462,6 +464,7 @@ static int action_a2n(char *arg, int *result, bool allow_num)
> 		{"reclassify", TC_ACT_RECLASSIFY},
> 		{"pipe", TC_ACT_PIPE},
> 		{"goto", TC_ACT_GOTO_CHAIN},
>+		{"trap", TC_ACT_TRAP},
> 		{ NULL },
> 	}, *iter;
> 
>-- 
>2.9.3
>