Subject: Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

From: Antoine Tenart <[email-masked]>
Date: Thu, 8 Jun 2017 11:03:07 +0200

Hi Gregory,

On Thu, Jun 08, 2017 at 10:55:01AM +0200, Gregory CLEMENT wrote:
>  On jeu., juin 08 2017, Antoine Tenart <[email-masked]> wrote:
> > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote:
> >> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> >> index 2a99ff8fca2a..594356243ddb 100644
> >> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> >> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> >> @@ -103,6 +103,13 @@
> >>  				clocks = <&cps_syscon0 1 9>, <&cps_syscon0 1 5>;
> >>  			};
> >>  
> >> +			cps_xmdio: mdio@12a600 {
> >> +				#address-cells = <1>;
> >> +				#size-cells = <0>;
> >> +				compatible = "marvell,xmdio";
> >> +				reg = <0x12a600 0x10>;
> >> +			};
> >> +
> >
> > Russell pointed out on IRC the mdio/xmdio interfaces aren't wired to
> > anything on the mcbin. We could either disable these interfaces by
> > default, or add explicit disables in the mcbin device tree.
> >
> > What's your thoughts on this?
> 
> I prefer that we disable it by default and only enable it on the boards
> using it.

OK. I'll add a disabled status property in this patch, and I'll make
another series to fix the existing mdio nodes.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com