Subject: Re: [RFC] networking: introduce and use skb_put_data()

From: Stephen Hemminger <[email-masked]>
Date: Thu, 15 Jun 2017 08:40:01 -0700

On Thu, 15 Jun 2017 09:10:18 +0200
Johannes Berg <[email-masked]> wrote:

> From: Johannes Berg <[email-masked]>
> 
> A common pattern with skb_put() is to just want to memcpy()
> some data into the new space, introduce skb_put_data() for
> this.
> 
> An spatch similar to the one for skb_put_zero() converts many
> of the places using it:
> 
>     @@
>     identifier p, p2;
>     expression len, skb, data;
>     type t, t2;
>     @@
>     (
>     -p = skb_put(skb, len);
>     +p = skb_put_data(skb, data, len);
>     |
>     -p = (t)skb_put(skb, len);
>     +p = skb_put_data(skb, data, len);
>     )
>     (
>     p2 = (t2)p;
>     -memcpy(p2, data, len);
>     |
>     -memcpy(p, data, len);
>     )
> 
>     @@
>     type t, t2;
>     identifier p, p2;
>     expression skb, data;
>     @@
>     t *p;
>     ...
>     (
>     -p = skb_put(skb, sizeof(t));
>     +p = skb_put_data(skb, data, sizeof(t));
>     |
>     -p = (t *)skb_put(skb, sizeof(t));
>     +p = skb_put_data(skb, data, sizeof(t));
>     )
>     (
>     p2 = (t2)p;
>     -memcpy(p2, data, sizeof(*p));
>     |
>     -memcpy(p, data, sizeof(*p));
>     )
> 
>     @@
>     expression skb, len, data;
>     @@
>     -memcpy(skb_put(skb, len), data, len);
>     +skb_put_data(skb, data, len);
> 
> (again, manually post-processed to retain some comments)
> 
> Signed-off-by: Johannes Berg <[email-masked]>

LGTM

Reviewed-by: Stephen Hemminger <[email-masked]>