Subject: Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly

From: Stephen Hemminger <[email-masked]>
Date: Wed, 21 Jun 2017 16:19:05 -0700

On Thu, 22 Jun 2017 00:16:37 +0200
Arnd Bergmann <[email-masked]> wrote:

> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
> 
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
> drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> 
> As the value is only set once to the argument of alloc_netdev_mq(),
> we can compare against that constant directly.
> 
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels")
> Signed-off-by: Arnd Bergmann <[email-masked]>

Yes this makes sense. The checks when changing values with ethtool are to avoid
to large a value > 64.

Signed-off-by: Stephen Hemminger <[email-masked]>