From: Andrew Lunn <andrew@lunn•ch>
To: Dan Carpenter <dan.carpenter@oracle•com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()
Date: Sat, 24 Jun 2017 05:21:24 +0200 [thread overview]
Message-ID: <20170624032124.GI4875@lunn.ch> (raw)
In-Reply-To: <20170623151703.stzh2ur3wizbylbi@mwanda>
On Fri, Jun 23, 2017 at 06:17:04PM +0300, Dan Carpenter wrote:
> We're accidentally returning the wrong variable. "cmode" is
> uninitialized at this point so it causes a static checker warning.
>
> Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2017-06-24 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 15:17 [PATCH net-next] net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power() Dan Carpenter
2017-06-24 3:21 ` Andrew Lunn [this message]
2017-06-25 15:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624032124.GI4875@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox