From: Andrew Lunn <andrew@lunn•ch>
To: Gal Pressman <galp@mellanox•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
"John W. Linville" <linville@tuxdriver•com>,
Saeed Mahameed <saeedm@mellanox•com>,
Vidya Sagar Ravipati <vidya@cumulusnetworks•com>,
Jiri Pirko <jiri@mellanox•com>,
David Decotigny <decot@googlers•com>,
kernel-team@fb•com
Subject: Re: [RFC PATCH net-next 1/3] ethtool: Add link down reason callback
Date: Sat, 24 Jun 2017 21:04:35 +0200 [thread overview]
Message-ID: <20170624190435.GN4875@lunn.ch> (raw)
In-Reply-To: <8e7ffead-350e-bd7f-c7ea-fe057969d0d3@mellanox.com>
On Thu, Jun 22, 2017 at 11:09:04AM +0300, Gal Pressman wrote:
>
> >> +enum {
> >> + ETHTOOL_LINK_VENDOR_SPECIFIC = -1, /* Vendor specific issue provided in vendor_reason */
> >> + ETHTOOL_LINK_NO_ISSUE, /* No issue observed with link */
> >> + ETHTOOL_LINK_REASON_UNKNOWN, /* Unknown reason */
> > I think OTHER would be better that UNKNOWN.
>
> Fine with me.
> >> + ETHTOOL_LINK_NETDEV_CARRIER_DOWN, /* Netdev carrier is down */
> >> + ETHTOOL_LINK_ADMIN_DOWN, /* Admin down */
> > These two are interesting. We have that information already. Why do we
> > want it again?
>
> My goal is to gather all link issue reasons in one place.
I'm actually wondering if this is a user space problem. Nearly
everything you list is already available. Some you get from ip link,
others from ethtool or ethtool --module-info, including I2C bus
error, since you would expect EIO or ETIMEOUT.
If you were to write a user space tool using the information what is
currently available, what would be missing?
Andrew
next prev parent reply other threads:[~2017-06-24 19:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 13:04 [RFC PATCH net-next 0/3] ethtool: Add link down reason reporting Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 1/3] ethtool: Add link down reason callback Gal Pressman
2017-06-21 13:58 ` Andrew Lunn
2017-06-22 8:09 ` Gal Pressman
2017-06-22 13:34 ` Andrew Lunn
2017-06-23 8:23 ` Gal Pressman
2017-06-23 13:52 ` Andrew Lunn
2017-06-24 19:04 ` Andrew Lunn [this message]
2017-06-25 11:59 ` Gal Pressman
2017-06-25 15:19 ` Andrew Lunn
2017-06-26 11:52 ` Gal Pressman
2017-06-26 13:34 ` Andrew Lunn
2017-06-27 19:40 ` David Miller
2017-06-21 15:43 ` Stephen Hemminger
2017-06-22 10:33 ` Gal Pressman
2017-06-26 13:28 ` Andrew Lunn
2017-06-26 15:48 ` Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 2/3] net/mlx5: Add PDDR register infrastructure Gal Pressman
2017-06-21 13:04 ` [RFC PATCH net-next 3/3] net/mlx5e: Expose link down reason to ethtool Gal Pressman
2017-06-21 14:03 ` Andrew Lunn
2017-06-22 8:17 ` Gal Pressman
2017-06-22 4:33 ` Jakub Kicinski
2017-06-22 8:33 ` Gal Pressman
2017-06-22 22:38 ` Jakub Kicinski
2017-06-23 8:52 ` Gal Pressman
2017-06-21 15:44 ` [RFC PATCH net-next 0/3] ethtool: Add link down reason reporting Stephen Hemminger
2017-06-22 11:13 ` Gal Pressman
2017-06-22 4:14 ` Jakub Kicinski
2017-06-22 11:37 ` Gal Pressman
2017-06-22 21:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624190435.GN4875@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=decot@googlers$(echo .)com \
--cc=galp@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=kernel-team@fb$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
--cc=vidya@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox