Subject: Re: [iproute PATCH] ip netns: Make sure netns name is sane

From: Stephen Hemminger <[email-masked]>
Date: Wed, 12 Jul 2017 09:38:34 -0700

On Mon, 10 Jul 2017 13:19:12 +0200
Phil Sutter <[email-masked]> wrote:

> +static bool is_basename(const char *name)
> +{
> +	char *name_dup = strdup(name);
> +	bool rc = true;
> +
> +	if (!name_dup)
> +		return false;
> +
> +	if (strcmp(basename(name_dup), name))
> +		rc = false;
> +
> +	free(name_dup);
> +	return rc;
> +}

Looks like natural place to use strdupa.

static bool is_basename(const char *name)
{
	return strcmp(basename(strdupa(name), name) == 0;
}