From: Stephen Hemminger <stephen@networkplumber•org>
To: Phil Sutter <phil@nwl•cc>
Cc: Hangbin Liu <liuhangbin@gmail•com>,
netdev@vger•kernel.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Subject: Re: [PATCHv2 iproute2] utils: return default family when rtm_family is not RTNL_FAMILY_IPMR/IP6MR
Date: Thu, 27 Jul 2017 11:28:45 -0700 [thread overview]
Message-ID: <20170727112845.666f9f94@xeon-e3> (raw)
In-Reply-To: <20170727100302.GP2235@orbyte.nwl.cc>
On Thu, 27 Jul 2017 12:03:02 +0200
Phil Sutter <phil@nwl•cc> wrote:
> On Thu, Jul 27, 2017 at 05:44:15PM +0800, Hangbin Liu wrote:
> > When we get a multicast route, the rtm_type is RTN_MULTICAST, but the
> > rtm_family may be AF_INET. If we only check the type with RTNL_FAMILY_IPMR,
> > we will get malformed address. e.g.
> >
> > + ip -4 route add multicast 172.111.1.1 dev em1 table main
> >
> > Before fix:
> > + ip route list type multicast table main
> > multicast ac6f:101:800:400:400:0:3c00:0 dev em1 scope link
> >
> > After fix:
> > + ip route list type multicast table main
> > multicast 172.111.1.1 dev em1 scope link
> >
> > Fixes: 56e3eb4c3400 ("ip: route: fix multicast route dumps")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail•com>
>
> Acked-by: Phil Sutter <phil@nwl•cc>
Applied, thanks.
prev parent reply other threads:[~2017-07-27 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 9:01 [PATCH iproute2] utils: also check AF_INET family when rtm_type is RTN_MULTICAST Hangbin Liu
2017-07-27 9:11 ` Phil Sutter
2017-07-27 9:44 ` [PATCHv2 iproute2] utils: return default family when rtm_family is not RTNL_FAMILY_IPMR/IP6MR Hangbin Liu
2017-07-27 10:03 ` Phil Sutter
2017-07-27 18:28 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727112845.666f9f94@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=phil@nwl$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox