From: Ido Schimmel <idosch@idosch•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: "Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
"Linux Kernel Network Developers" <netdev@vger•kernel.org>
Subject: Re: [v4.12 regression] netns: NULL deref in fib_sync_down_dev()
Date: Fri, 28 Jul 2017 20:36:02 +0300 [thread overview]
Message-ID: <20170728173602.GA30482@splinter> (raw)
In-Reply-To: <CAM_iQpXmUfdUzsu7Xpc2EjkePQCEjcP+irMkpc4bTDaWfAOVLw@mail.gmail.com>
On Fri, Jul 28, 2017 at 10:28:16AM -0700, Cong Wang wrote:
> On Fri, Jul 28, 2017 at 9:43 AM, Ido Schimmel <idosch@idosch•org> wrote:
> > On Fri, Jul 28, 2017 at 06:00:47PM +0200, Michał Mirosław wrote:
> >> Dear NetDevs,
> >>
> >> Before I go to bisecting, have you seen a following NULL dereference,
> >> yet? Where should I start looking? It is triggered by deleting netns
> >> (cut-down script attached - triggers every time). This was working
> >> correctly under v4.11.x.
> >
> > Thanks for the report. I just reproduced this on my system. I believe
> > the problem is a missing NULL check for 'in_dev' in
> > call_fib_nh_notifiers(). I'll test a fix.
>
> But your commit 982acb97560c8118c2109504a22b0d78a580547d
> is merged in v4.11-rc1. How could 4.11.x work correctly?
It doesn't. I just reproduced this on v4.11.
next prev parent reply other threads:[~2017-07-28 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 16:00 [v4.12 regression] netns: NULL deref in fib_sync_down_dev() Michał Mirosław
2017-07-28 16:43 ` Ido Schimmel
2017-07-28 17:28 ` Cong Wang
2017-07-28 17:36 ` Ido Schimmel [this message]
2017-07-28 18:04 ` Michał Mirosław
2017-07-28 19:08 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728173602.GA30482@splinter \
--to=idosch@idosch$(echo .)org \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox