Subject: Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters

From: Florian Westphal <[email-masked]>
Date: Sat, 29 Jul 2017 22:03:43 +0200

Julia Lawall <[email-masked]> wrote:
> When a nf_conntrack_l3/4proto parameter is not on the left hand side
> of an assignment, its address is not taken, and it is not passed to a
> function that may modify its fields, then it can be declared as const.
> 
> This change is useful from a documentation point of view, and can
> possibly facilitate making some nf_conntrack_l3/4proto structures const
> subsequently.
> 
> Done with the help of Coccinelle.
> 
> Some spacing adjusted to fit within 80 characters.

Acked-by: Florian Westphal <[email-masked]>

Thanks Julia.

I think we can indeed constify these completely after making
'nla_size' set at compile time.

I'll send a simple attempt to make it so for l3proto soon.