From: Andrew Lunn <andrew@lunn•ch>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, fugang.duan@nxp•com
Subject: Re: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes
Date: Mon, 31 Jul 2017 04:27:26 +0200 [thread overview]
Message-ID: <20170731022726.GA30155@lunn.ch> (raw)
In-Reply-To: <20170730.192629.124814765201077334.davem@davemloft.net>
On Sun, Jul 30, 2017 at 07:26:29PM -0700, David Miller wrote:
> From: Andrew Lunn <andrew@lunn•ch>
> Date: Sun, 30 Jul 2017 19:36:05 +0200
>
> > The FEC Receive Control Register has a 14 bit field indicating the
> > longest frame that my be received. It is being set to 1522. Frames
> > longer than this are discarded, but counted as being in error.
> >
> > When using DSA, frames from the switch has an additional header,
> > either 4 or 8 bytes if a Marvell switch is used. Thus a full MTU frame
> > of 1522 bytes received by the switch on a port becomes 1530 bytes when
> > passed to the host via the FEC interface.
> >
> > Change the maximum receive size to 2048 - 64, where 64 is the maximum
> > rx_alignment applied on the receive buffer for AVB capable FEC
> > cores. Use this value also for the maximum receive buffer size. The
> > driver is already allocating a receive SKB of 2048 bytes, so this
> > change should not have any significant effects.
> >
> > Tested on imx51, imx6, vf610.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn•ch>
>
> Applied with commit log message typo fixed.
Hi David
Thanks for fixing the typo.
Andrew
prev parent reply other threads:[~2017-07-31 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 17:36 [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes Andrew Lunn
2017-07-31 1:41 ` Andy Duan
2017-07-31 2:26 ` David Miller
2017-07-31 2:27 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731022726.GA30155@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=fugang.duan@nxp$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox