Subject: Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

From: Stephen Hemminger <[email-masked]>
Date: Mon, 31 Jul 2017 20:51:33 -0700

On Mon, 31 Jul 2017 17:40:50 -0700
Amritha Nambiar <[email-masked]> wrote:
The concept is fine, bu t the code looks different than the rest which
is never a good sign.

> +				if ((argc > 0) && (matches(*argv, "tc") == 0)) {

Extra () are unnecessary in compound conditional.

> +					tc = atoi(*argv);

Prefer using strtoul since it has better error handling than atoi()

> +					argc--;
> +					argv++;
> +				}

Use NEXT_ARG() construct like rest of the code.