Subject: Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.

From: Stephen Hemminger <[email-masked]>
Date: Tue, 1 Aug 2017 07:49:31 -0700

On Tue,  1 Aug 2017 17:50:05 +0800
mohamedalrshah <[email-masked]> wrote:

> From: Mohamed Alrshah <[email-masked]>
> 

Please add more background on Agile-SD in the email commit message.

> +static struct tcp_congestion_ops agilesdtcp __read_mostly = {
> +	.init		= agilesdtcp_init,
> +	.ssthresh	= agilesdtcp_recalc_ssthresh, 	//REQUIRED
> +	.cong_avoid	= agilesdtcp_cong_avoid, 	//REQUIRED
> +	.set_state	= agilesdtcp_state,
> +	.undo_cwnd	= agilesdtcp_undo_cwnd,
> +	.pkts_acked	= agilesdtcp_acked,
> +	.owner		= THIS_MODULE,
> +	.name		= "agilesd", 			//REQUIRED
> +	//.min_cwnd	= agilesdtcp_min_cwnd, 		//NOT REQUIRED
> +};

Your code must match kernel coding style. See Documentation for more
info and use the checkpatch.pl checking script.