From: Stephen Hemminger <stephen@networkplumber•org>
To: Phil Sutter <phil@nwl•cc>
Cc: netdev@vger•kernel.org
Subject: Re: [iproute PATCH] Really fix get_addr() and get_prefix() error messages
Date: Thu, 3 Aug 2017 16:02:07 -0700 [thread overview]
Message-ID: <20170803160207.0839d387@xeon-e3> (raw)
In-Reply-To: <20170801163611.10094-1-phil@nwl.cc>
On Tue, 1 Aug 2017 18:36:11 +0200
Phil Sutter <phil@nwl•cc> wrote:
> Both functions take the desired address family as a parameter. So using
> that to notify the user what address family was expected is correct,
> unlike using dst->family which will tell the user only what address
> family was specified.
>
> The situation which commit 334af76143368 tried to fix was when 'ip'
> would accept addresses from multiple families. In that case, the family
> parameter is set to AF_UNSPEC so that get_addr_1() may accept any valid
> address.
>
> This patch introduces a wrapper around family_name() which returns the
> string "any valid" for AF_UNSPEC instead of the three question marks
> unsuitable for use in error messages.
>
> Tests for AF_UNSPEC:
>
> | # ip a a 256.10.166.1/24 dev d0
> | Error: any valid prefix is expected rather than "256.10.166.1/24".
>
> | # ip neighbor add proxy 2001:db8::g dev d0
> | Error: any valid address is expected rather than "2001:db8::g".
>
> Tests for explicit address family:
>
> | # ip -6 addrlabel add prefix 1.1.1.1/24 label 123
> | Error: inet6 prefix is expected rather than "1.1.1.1/24".
>
> | # ip -4 addrlabel add prefix dead:beef::1/24 label 123
> | Error: inet prefix is expected rather than "dead:beef::1/24".
>
> Reported-by: Jaroslav Aster <jaster@redhat•com>
> Fixes: 334af76143368 ("fix get_addr() and get_prefix() error messages")
> Signed-off-by: Phil Sutter <phil@nwl•cc>
Moderately more helpful, so sure.
prev parent reply other threads:[~2017-08-03 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:36 [iproute PATCH] Really fix get_addr() and get_prefix() error messages Phil Sutter
2017-08-03 23:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803160207.0839d387@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox