From: Stephen Hemminger <stephen@networkplumber•org>
To: Casey Callendrello <casey.callendrello@coreos•com>
Cc: netdev@vger•kernel.org, "Eric W. Biederman" <ebiederm@xmission•com>
Subject: Re: [PATCH iproute2] netns: make /var/run/netns bind-mount recursive
Date: Thu, 3 Aug 2017 16:04:21 -0700 [thread overview]
Message-ID: <20170803160421.58eb0a4a@xeon-e3> (raw)
In-Reply-To: <20170801154609.29895-1-casey.callendrello@coreos.com>
On Tue, 1 Aug 2017 17:46:09 +0200
Casey Callendrello <casey.callendrello@coreos•com> wrote:
> When ip netns {add|delete} is first run, it bind-mounts /var/run/netns
> on top of itself, then marks it as shared. However, if there are already
> bind-mounts in the directory from other tools, these would not be
> propagated. Fix this by recursively bind-mounting.
>
> Signed-off-by: Casey Callendrello <casey.callendrello@coreos•com>
> ---
> ip/ipnetns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Looks good, but I want a review by Eric to make sure this doesn't break other things.
next prev parent reply other threads:[~2017-08-03 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 15:46 [PATCH iproute2] netns: make /var/run/netns bind-mount recursive Casey Callendrello
2017-08-03 23:04 ` Stephen Hemminger [this message]
2017-08-04 13:41 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803160421.58eb0a4a@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=casey.callendrello@coreos$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox