From: Stephen Hemminger <stephen@networkplumber•org>
To: Jamal Hadi Salim <jhs@mojatatu•com>
Cc: netdev@vger•kernel.org, jiri@resnulli•us,
xiyou.wangcong@gmail•com, eric.dumazet@gmail•com,
dsahern@gmail•com
Subject: Re: [PATCH iproute2 1/2] tc actions: Improved batching and time filtered dumping
Date: Fri, 4 Aug 2017 13:17:41 -0700 [thread overview]
Message-ID: <20170804131741.2145008c@xeon-e3> (raw)
In-Reply-To: <1501674387-15001-1-git-send-email-jhs@emojatatu.com>
On Wed, 2 Aug 2017 07:46:26 -0400
Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> From: Jamal Hadi Salim <jhs@mojatatu•com>
>
> dump more than TCA_ACT_MAX_PRIO actions per batch when the kernel
> supports it.
>
> Introduced keyword "since" for time based filtering of actions.
> Some example (we have 400 actions bound to 400 filters); at
> installation time. Using updated when tc setting the time of
> interest to 120 seconds earlier (we see 400 actions):
> prompt$ hackedtc actions ls action gact since 120000| grep index | wc -l
> 400
>
> go get some coffee and wait for > 120 seconds and try again:
>
> prompt$ hackedtc actions ls action gact since 120000 | grep index | wc -l
> 0
>
> Lets see a filter bound to one of these actions:
> ....
> filter pref 10 u32
> filter pref 10 u32 fh 800: ht divisor 1
> filter pref 10 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:10 (rule hit 2 success 1)
> match 7f000002/ffffffff at 12 (success 1 )
> action order 1: gact action pass
> random type none pass val 0
> index 23 ref 2 bind 1 installed 1145 sec used 802 sec
> Action statistics:
> Sent 84 bytes 1 pkt (dropped 0, overlimits 0 requeues 0)
> backlog 0b 0p requeues 0
> ...
>
> that coffee took long, no? It was good.
>
> Now lets ping -c 1 127.0.0.2, then run the actions again:
> prompt$ hackedtc actions ls action gact since 120 | grep index | wc -l
> 1
>
> More details please:
> prompt$ hackedtc -s actions ls action gact since 120000
>
> action order 0: gact action pass
> random type none pass val 0
> index 23 ref 2 bind 1 installed 1270 sec used 30 sec
> Action statistics:
> Sent 168 bytes 2 pkt (dropped 0, overlimits 0 requeues 0)
> backlog 0b 0p requeues 0
>
> And the filter?
> filter pref 10 u32
> filter pref 10 u32 fh 800: ht divisor 1
> filter pref 10 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:10 (rule hit 4 success 2)
> match 7f000002/ffffffff at 12 (success 2 )
> action order 1: gact action pass
> random type none pass val 0
> index 23 ref 2 bind 1 installed 1324 sec used 84 sec
> Action statistics:
> Sent 168 bytes 2 pkt (dropped 0, overlimits 0 requeues 0)
> backlog 0b 0p requeues 0
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu•com>
Applied to net-next branch. Thanks Jamal
prev parent reply other threads:[~2017-08-04 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:46 [PATCH iproute2 1/2] tc actions: Improved batching and time filtered dumping Jamal Hadi Salim
2017-08-02 11:46 ` [PATCH iproute2 2/2] actions: update the man page to describe the "since" time filter Jamal Hadi Salim
2017-08-04 20:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804131741.2145008c@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=dsahern@gmail$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox