Subject: Re: [PATCH v5] ss: Enclose IPv6 address in brackets

From: Stephen Hemminger <[email-masked]>
Date: Fri, 4 Aug 2017 15:13:26 -0700

On Fri, 04 Aug 2017 13:46:27 -0700
Eric Dumazet <[email-masked]> wrote:

> On Fri, 2017-08-04 at 12:05 -0700, Stephen Hemminger wrote:
> > On Fri, 4 Aug 2017 20:02:52 +0200
> > Florian Lehner <[email-masked]> wrote:
> >   
> > > diff --git a/misc/ss.c b/misc/ss.c
> > > index 12763c9..83683b5 100644
> > > --- a/misc/ss.c
> > > +++ b/misc/ss.c
> > > @@ -1046,8 +1046,9 @@ do_numeric:
> > > 
> > >  static void inet_addr_print(const inet_prefix *a, int port, unsigned
> > > int ifindex)
> > >  {  
> > 
> > Your email client is wrapping long lines which leads to malformed patch.
> > 
> > You didn't need buf2, and the code was more complex than it needed to be.
> > 
> > Rather than waiting for yet another version, I just merged in similar
> > code.  
> 
> 
> Also, is this new format accepted for the filter ?
> 
> ss src [::1]:22

It looks like ss would always do that (from earliest git version).