From: Stephen Hemminger <stephen@networkplumber•org>
To: Daniel Borkmann <daniel@iogearbox•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader
Date: Thu, 10 Aug 2017 16:41:31 -0700 [thread overview]
Message-ID: <20170810164131.3bf0ef89@xeon-e3> (raw)
In-Reply-To: <598C1CDD.3090604@iogearbox.net>
On Thu, 10 Aug 2017 10:44:13 +0200
Daniel Borkmann <daniel@iogearbox•net> wrote:
> On 08/10/2017 02:35 AM, Stephen Hemminger wrote:
> > On Thu, 10 Aug 2017 00:15:41 +0200
> > Daniel Borkmann <daniel@iogearbox•net> wrote:
> >
> >> Commit 69fed534a533 ("change how Config is used in Makefile's") moved
> >> HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the
> >> top level Makefile into sub-Makefiles. However, it also removed the
> >> HAVE_ELF specific CFLAGS/LDLIBS entirely, which breaks the BPF object
> >> loader for tc and ip with "No ELF library support compiled in." despite
> >> having libelf detected in configure script. Fix it similarly as in
> >> 69fed534a533 for HAVE_ELF.
> >>
> >> Fixes: 69fed534a533 ("change how Config is used in Makefile's")
> >> Reported-by: Jeffrey Panneman <jeffrey.panneman@tno•nl>
> >> Signed-off-by: Daniel Borkmann <daniel@iogearbox•net>
> >
> > Thanks, but I am thinking maybe a better solution long term would be to
> > move all the package specific stuff into the generated Config file.
> >
> > That way only the generation shell script would have to change.
> >
> > Also, all the flags should probably be using pkg-config to get the values.
>
> Sure, sounds all good, for the time being, I would like to have
> that breakage undone though, so users can work with loading BPF
> programs again on -master.
>
> Thanks,
> Daniel
Agree. I will merge this for master, and work on better config management
in net-next.
next prev parent reply other threads:[~2017-08-10 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 22:15 [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader Daniel Borkmann
2017-08-10 0:35 ` Stephen Hemminger
2017-08-10 8:44 ` Daniel Borkmann
2017-08-10 23:41 ` Stephen Hemminger [this message]
2017-08-11 8:56 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810164131.3bf0ef89@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox