Subject: Re: [PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses warning

From: Pablo Neira Ayuso <[email-masked]>
Date: Fri, 11 Aug 2017 19:42:59 +0200

Hi Nick,

On Mon, Jul 31, 2017 at 11:39:49AM -0700, Nick Desaulniers wrote:
> Clang produces the following warning:
[...]
> Also, it's even cleaner to use the form:
> 
> if (x)
> 
> but then if the return codes change from treating 0 as success (unlikely),
> then all call sites must be updated.
> 
> I'm happy to send v2 that changes to that form, and updates the other call
> sites to be:
> 
> if (set_h225_addr())
>   handle_failures()
> else
>   handle_success()

That sounds very reasonable, send a v2 if this triggers a larger
patch.

Or I can just take this patch, as you prefer.

Thanks!