Subject: Re: [iproute PATCH 01/51] devlink: Check return code of strslashrsplit()

From: Stephen Hemminger <[email-masked]>
Date: Tue, 15 Aug 2017 08:09:54 -0700

On Sat, 12 Aug 2017 14:04:20 +0200
Phil Sutter <[email-masked]> wrote:

> This function shouldn't fail because all callers of
> __dl_argv_handle_port() make sure the passed string contains enough
> slashes already, but better make sure if this changes in future the
> function won't access uninitialized data.
> 
> Signed-off-by: Phil Sutter <[email-masked]>

Ok, but please don't go too far down the dead end of addressing all possible
"if code changes in the future this would be a bug". Keep to finding
and fixing the real bugs that exist today.