Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface

From: Stephen Hemminger <[email-masked]>
Date: Thu, 17 Aug 2017 17:42:05 -0700

On Thu, 17 Aug 2017 19:52:42 +0800
Aviad Krawczyk <[email-masked]> wrote:

> +
> +/**
> + * init_pfhwdev - Initialize the extended components of PF
> + * @pfhwdev: the HW device for PF
> + *
> + * Return 0 - success, negative - failure
> + **/
> +static int init_pfhwdev(struct hinic_pfhwdev *pfhwdev)
> +{
> +	/* Initialize PF HW device extended components */
> +	return 0;
> +}
> +
> +/**
> + * free_pfhwdev - Free the extended components of PF
> + * @pfhwdev: the HW device for PF
> + **/
> +static void free_pfhwdev(struct hinic_pfhwdev *pfhwdev)
> +{
> +}

Please drop these functions, they do nothing and are not used
as stubs in any operations table.