From: Andrew Lunn <andrew@lunn•ch>
To: Antoine Tenart <antoine.tenart@free-electrons•com>
Cc: davem@davemloft•net, jason@lakedaemon•net,
gregory.clement@free-electrons•com,
sebastian.hesselbarth@gmail•com,
thomas.petazzoni@free-electrons•com, nadavh@marvell•com,
linux@armlinux•org.uk, mw@semihalf•com, stefanc@marvell•com,
netdev@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY
Date: Tue, 22 Aug 2017 16:50:14 +0200 [thread overview]
Message-ID: <20170822145014.GB18076@lunn.ch> (raw)
In-Reply-To: <20170822144101.GC14942@kwain>
> > It is still not clear to my why you need to program the address into
> > the hardware. Is the hardware talking to the PHY?
>
> Sorry for the answer delay, I was out of the office...
>
> This PHY address configuration should be done in the mvmdio driver as
> this is not directly related to the PPv2 (well, the mvmdio driver is
> only an abstraction to reuse the mdio code, using registers exposed by
> PPv2 in this case anyway). But two values must be known in order to do
> this: the PHY address and the GoP port number. Getting the last one from
> the mvmdio driver would be really ugly as we would need to read the PPv2
> dt node. This is why this patch adds it in the PPv2 driver, but I know
> it's not perfect.
>
> I'll resend a series very soon, with this patch still included. We can
> continue the discussion there I guess, if needed.
>
> Thanks!
Hi Antoine
You have still not explained why PPv2 needs to know the PHY address.
What i'm worried about is that the PPv2 is actually talking to the
PHY. Is it polling link state? Does it take the PHY mutex when it does
this poll?
Andrew
next prev parent reply other threads:[~2017-08-22 14:50 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 13:48 [PATCH net-next 00/18] net: mvpp2: MAC/GoP configuration and optional PHYs Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 01/18] net: mvpp2: unify register definitions coding style Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 02/18] net: mvpp2: fix the synchronization module bypass macro name Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY Antoine Tenart
2017-07-24 16:40 ` Sergei Shtylyov
2017-07-25 8:42 ` Antoine Tenart
2017-07-26 16:08 ` Andrew Lunn
2017-07-28 1:49 ` Antoine Tenart
2017-07-28 4:21 ` Andrew Lunn
2017-08-22 14:41 ` Antoine Tenart
2017-08-22 14:50 ` Andrew Lunn [this message]
2017-08-23 10:40 ` [EXT] " Stefan Chulski
2017-08-23 12:34 ` Andrew Lunn
2017-08-23 13:30 ` Stefan Chulski
2017-08-23 13:34 ` Andrew Lunn
2017-07-24 13:48 ` [PATCH net-next 04/18] net: mvpp2: move the mii configuration in the ndo_open path Antoine Tenart
2017-07-26 16:11 ` Andrew Lunn
2017-07-28 1:44 ` Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 05/18] net: mvpp2: initialize the GMAC when using a port Antoine Tenart
2017-07-26 16:14 ` Andrew Lunn
2017-07-24 13:48 ` [PATCH net-next 06/18] net: mvpp2: initialize the XLG MAC " Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 07/18] net: mvpp2: initialize the GoP Antoine Tenart
2017-07-26 16:16 ` Andrew Lunn
2017-07-24 13:48 ` [PATCH net-next 08/18] net: mvpp2: make the phy optional Antoine Tenart
2017-07-26 16:20 ` Andrew Lunn
2017-07-28 1:50 ` Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 09/18] net: mvpp2: use named interrupts Antoine Tenart
2017-07-24 16:49 ` Sergei Shtylyov
2017-07-25 8:45 ` Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes Antoine Tenart
2017-07-24 22:58 ` Marcin Wojtas
2017-07-25 8:47 ` Antoine Tenart
2017-07-25 13:17 ` Thomas Petazzoni
2017-07-26 0:07 ` Antoine Tenart
2017-07-26 16:26 ` Andrew Lunn
2017-07-26 19:38 ` Russell King - ARM Linux
2017-08-23 8:25 ` Antoine Tenart
2017-08-23 15:24 ` [EXT] " Stefan Chulski
2017-08-23 16:04 ` Antoine Tenart
2017-08-23 21:05 ` Marcin Wojtas
2017-08-24 10:59 ` Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 11/18] Documentation/bindings: net: marvell-pp2: add the system controller Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 12/18] Documentation/bindings: net: marvell-pp2: add the interrupt-names Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 13/18] arm64: dts: marvell: cp110: use named interrupts for the Ethernet ports Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 14/18] arm64: dts: marvell: cp110: add PPv2 port interrupts Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 15/18] arm64: dts: marvell: add a reference to the sysctrl syscon in the ppv2 node Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 16/18] arm64: dts: marvell: mcbin: enable more networking ports Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 17/18] arm64: dts: marvell: 7040-db: enable the SFP port Antoine Tenart
2017-07-24 13:48 ` [PATCH net-next 18/18] arm64: dts: marvell: 8040-db: enable the SFP ports Antoine Tenart
2017-07-24 23:56 ` [PATCH net-next 00/18] net: mvpp2: MAC/GoP configuration and optional PHYs Marcin Wojtas
2017-07-25 8:48 ` Antoine Tenart
2017-07-25 10:45 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822145014.GB18076@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=antoine.tenart@free-electrons$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=nadavh@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=stefanc@marvell$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox