From: Florian Westphal <fw@strlen•de>
To: Denys Fedoryshchenko <nuclearcat@nuclearcat•com>
Cc: Florian Westphal <fw@strlen•de>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: nf_nat_pptp 4.12.3 kernel lockup/reboot
Date: Fri, 25 Aug 2017 07:21:37 +0200 [thread overview]
Message-ID: <20170825052137.GF15739@breakpoint.cc> (raw)
In-Reply-To: <f31c9ddfc1d4e02ff7fc16d3a0955841@nuclearcat.com>
Denys Fedoryshchenko <nuclearcat@nuclearcat•com> wrote:
> >>> I am trying to upgrade kernel 4.11.8 to 4.12.3 (it is a nat/router, handling
> >>> approx 2gbps of pppoe users traffic) and noticed that after while server
> >>> rebooting(i have set reboot on panic and etc).
> >>> I can't run serial console, and in pstore / netconsole there is nothing.
> >>> Best i got is some very short message about softlockup in ipmi, but as
> >>> storage very limited there - it is near useless.
> >>>
> >>> By preliminary testing (can't do it much, as it's production) - it seems
> >>> following lines causing issue, they worked in 4.11.8 and no more in 4.12.3.
> >>
> >>Wild guess here, does this help?
> >>
> >>diff --git a/net/netfilter/nf_conntrack_helper.c
> >>b/net/netfilter/nf_conntrack_helper.c
> >>--- a/net/netfilter/nf_conntrack_helper.c
> >>+++ b/net/netfilter/nf_conntrack_helper.c
> >>@@ -266,6 +266,8 @@ int __nf_ct_try_assign_helper(struct nf_conn *ct,
> >>struct nf_conn *tmpl,
> >> help = nf_ct_helper_ext_add(ct, helper, flags);
> >> if (help == NULL)
> >> return -ENOMEM;
> >>+ if (!nf_ct_ext_add(ct, NF_CT_EXT_NAT, flags));
> >
> >sigh, stupid typo, should be no ';' at the end above.
> Sorry, is there any plans to push this to 4.12 stable queue?
No, sorry, this patch adds the extension for all connections
that use a helper, but the nat extension is only used/required by pptp
helper (and masquerade).
Thing is that this patch should not be needed, I will have
to review pptp again, maybe i missed a case where the extension is not
added.
Do you happen to have an oops backtrace?
That might speed this up a bit.
next prev parent reply other threads:[~2017-08-25 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 14:12 nf_nat_pptp 4.12.3 kernel lockup/reboot Denys Fedoryshchenko
2017-07-24 16:19 ` Florian Westphal
2017-07-24 16:20 ` Florian Westphal
2017-07-25 7:27 ` Denys Fedoryshchenko
2017-07-27 6:29 ` Denys Fedoryshchenko
2017-08-25 2:58 ` Denys Fedoryshchenko
2017-08-25 5:21 ` Florian Westphal [this message]
2017-08-25 7:15 ` Denys Fedoryshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825052137.GF15739@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nuclearcat@nuclearcat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox