Subject: Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes

From: Antoine Tenart <[email-masked]>
Date: Thu, 31 Aug 2017 15:52:55 +0200

Hi Andrew,

On Thu, Aug 31, 2017 at 03:47:24PM +0200, Andrew Lunn wrote:
> On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:
> > +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)
> > +{
> > +	u32 val;
> > +
> > +	if (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||
> > +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> > +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> > +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||
> 
> phy_interface_mode_is_rgmii()

Right, and you already made that comment before... I'll fix it.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com