From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Kees Cook <keescook@chromium•org>
Cc: Thomas Gleixner <tglx@linutronix•de>,
Krzysztof Halasa <khc@pm•waw.pl>,
Aditya Shankar <aditya.shankar@microchip•com>,
Ganesh Krishna <ganesh.krishna@microchip•com>,
Jens Axboe <axboe@fb•com>,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
devel@driverdev•osuosl.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments
Date: Fri, 1 Sep 2017 07:09:10 +0200 [thread overview]
Message-ID: <20170901050910.GB2584@kroah.com> (raw)
In-Reply-To: <1504222183-61202-14-git-send-email-keescook@chromium.org>
On Thu, Aug 31, 2017 at 04:29:25PM -0700, Kees Cook wrote:
> Several timer users needlessly reset their .function/.data fields during
> their timer callback, but nothing else changes them. Some users do not
> use their .data field at all. Each instance is removed here.
>
> Cc: Krzysztof Halasa <khc@pm•waw.pl>
> Cc: Aditya Shankar <aditya.shankar@microchip•com>
> Cc: Ganesh Krishna <ganesh.krishna@microchip•com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Cc: Jens Axboe <axboe@fb•com>
> Cc: netdev@vger•kernel.org
> Cc: linux-wireless@vger•kernel.org
> Cc: devel@driverdev•osuosl.org
> Signed-off-by: Kees Cook <keescook@chromium•org>
> ---
> drivers/block/amiflop.c | 3 +--
> drivers/net/wan/hdlc_cisco.c | 2 --
> drivers/net/wan/hdlc_fr.c | 2 --
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +---
> 4 files changed, 2 insertions(+), 9 deletions(-)
For the staging driver:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
next prev parent reply other threads:[~2017-09-01 5:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1504222183-61202-1-git-send-email-keescook@chromium.org>
2017-08-31 23:29 ` [PATCH 13/31] timer: Remove meaningless .data/.function assignments Kees Cook
2017-09-01 5:09 ` Greg Kroah-Hartman [this message]
2017-09-01 17:59 ` Krzysztof Halasa
2017-09-01 20:07 ` Jens Axboe
2017-08-31 23:29 ` [PATCH 19/31] timer: Remove open-coded casts for .data and .function Kees Cook
2017-09-01 0:28 ` Tyrel Datwyler
2017-09-01 0:29 ` Tyrel Datwyler
2017-08-31 23:29 ` [PATCH 20/31] net/core: Collapse redundant sk_timer callback data assignments Kees Cook
2017-08-31 23:29 ` [PATCH 25/31] net/atm/mpc: Use separate static data field with with static timer Kees Cook
2017-08-31 23:29 ` [PATCH 30/31] appletalk: Remove unneeded synchronization Kees Cook
2017-08-31 23:29 ` [PATCH 31/31] timer: Switch to testing for .function instead of .data Kees Cook
2017-08-31 23:45 ` Dmitry Torokhov
2017-08-31 23:59 ` Kees Cook
[not found] ` <CAGXu5jK84cN9MdjfzaipD7GN8a37JMfD8X0Em4mk2_aFGuaOUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-01 1:06 ` Dmitry Torokhov
2017-09-01 21:34 ` Jeff Kirsher
2017-09-02 13:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901050910.GB2584@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=aditya.shankar@microchip$(echo .)com \
--cc=axboe@fb$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=ganesh.krishna@microchip$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=khc@pm$(echo .)waw.pl \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox