From: Steffen Klassert <steffen.klassert@secunet•com>
To: Alexey Kodanev <alexey.kodanev@oracle•com>
Cc: <netdev@vger•kernel.org>,
Herbert Xu <herbert@gondor•apana.org.au>,
"David Miller" <davem@davemloft•net>
Subject: Re: [PATCH] vti: fix NULL dereference in xfrm_input()
Date: Wed, 13 Sep 2017 12:44:16 +0200 [thread overview]
Message-ID: <20170913104416.GG31384@secunet.com> (raw)
In-Reply-To: <1505217226-31817-1-git-send-email-alexey.kodanev@oracle.com>
On Tue, Sep 12, 2017 at 02:53:46PM +0300, Alexey Kodanev wrote:
> Can be reproduced with LTP tests:
> # icmp-uni-vti.sh -p ah -a sha256 -m tunnel -S fffffffe -k 1 -s 10
>
> IPv4:
> RIP: 0010:xfrm_input+0x7f9/0x870
> ...
> Call Trace:
> <IRQ>
> vti_input+0xaa/0x110 [ip_vti]
> ? skb_free_head+0x21/0x40
> vti_rcv+0x33/0x40 [ip_vti]
> xfrm4_ah_rcv+0x33/0x60
> ip_local_deliver_finish+0x94/0x1e0
> ip_local_deliver+0x6f/0xe0
> ? ip_route_input_noref+0x28/0x50
> ...
>
> # icmp-uni-vti.sh -6 -p ah -a sha256 -m tunnel -S fffffffe -k 1 -s 10
> IPv6:
> RIP: 0010:xfrm_input+0x7f9/0x870
> ...
> Call Trace:
> <IRQ>
> xfrm6_rcv_tnl+0x3c/0x40
> vti6_rcv+0xd5/0xe0 [ip6_vti]
> xfrm6_ah_rcv+0x33/0x60
> ip6_input_finish+0xee/0x460
> ip6_input+0x3f/0xb0
> ip6_rcv_finish+0x45/0xa0
> ipv6_rcv+0x34b/0x540
>
> xfrm_input() invokes xfrm_rcv_cb() -> vti_rcv_cb(), the last callback
> might call skb_scrub_packet(), which in turn can reset secpath.
>
> Fix it by adding a check that skb->sp is not NULL.
>
> Fixes: 7e9e9202bccc ("xfrm: Clear RX SKB secpath xfrm_offload")
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle•com>
Patch applied, thanks Alexey!
prev parent reply other threads:[~2017-09-13 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 11:53 [PATCH] vti: fix NULL dereference in xfrm_input() Alexey Kodanev
2017-09-13 10:44 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913104416.GG31384@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=alexey.kodanev@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox