From: Stephen Hemminger <stephen@networkplumber•org>
To: Phil Sutter <phil@nwl•cc>
Cc: Hangbin Liu <liuhangbin@gmail•com>,
netdev@vger•kernel.org,
Julien Fortin <julien@cumulusnetworks•com>
Subject: Re: [iproute PATCH v2] ipaddress: Fix segfault in 'addr showdump'
Date: Wed, 20 Sep 2017 17:54:02 -0700 [thread overview]
Message-ID: <20170920175402.208117a7@xeon-e3> (raw)
In-Reply-To: <20170913092034.7002-1-phil@nwl.cc>
On Wed, 13 Sep 2017 11:20:34 +0200
Phil Sutter <phil@nwl•cc> wrote:
> Obviously, 'addr showdump' feature wasn't adjusted to json output
> support. As a consequence, calls to print_string() in print_addrinfo()
> tried to dereference a NULL FILE pointer.
>
> Cc: Julien Fortin <julien@cumulusnetworks•com>
> Fixes: d0e720111aad2 ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Phil Sutter <phil@nwl•cc>
> --
> Changes since v1:
> Align json output with that of 'ip -j addr show':
> - Interface index label is 'ifindex', not 'index' and it doesn't belong
> to 'addr_info' array.
> - Create one 'addr_info' array per dumped address, not one for all.
> ---
> ip/ipaddress.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
Looks good, applied.
prev parent reply other threads:[~2017-09-21 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 9:20 [iproute PATCH v2] ipaddress: Fix segfault in 'addr showdump' Phil Sutter
2017-09-15 3:05 ` Julien Fortin
2017-09-21 0:54 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920175402.208117a7@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=julien@cumulusnetworks$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox