From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@savoirfairelinux•com,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH net-next 2/4] net: dsa: remove phy arg from port enable/disable
Date: Fri, 22 Sep 2017 21:11:05 +0200 [thread overview]
Message-ID: <20170922191105.GF3470@lunn.ch> (raw)
In-Reply-To: <6d7799bb-2b33-0696-1805-63cea5e52667@gmail.com>
> Historical reasons mostly. Considering the complexity of
> dsa_slave_phy_setup(), I would certainly be extremely careful in
> changing any of this, the potential for breakage is pretty big.
Yes, i took a look at this, wondering how to convert to phylink. I
went away and got a stiff drink :-)
Andrew
next prev parent reply other threads:[~2017-09-22 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 16:17 [PATCH net-next 0/4] net: dsa: simplify port enabling Vivien Didelot
2017-09-22 16:17 ` [PATCH net-next 1/4] net: dsa: move up phy enabling in core Vivien Didelot
2017-09-22 16:32 ` Andrew Lunn
2017-09-22 16:58 ` Florian Fainelli
2017-09-22 16:52 ` Florian Fainelli
2017-09-22 16:17 ` [PATCH net-next 2/4] net: dsa: remove phy arg from port enable/disable Vivien Didelot
2017-09-22 17:14 ` Florian Fainelli
2017-09-22 18:12 ` Vivien Didelot
2017-09-22 18:23 ` Florian Fainelli
2017-09-22 19:11 ` Andrew Lunn [this message]
2017-09-22 16:17 ` [PATCH net-next 3/4] net: dsa: make slave close symmetrical to open Vivien Didelot
2017-09-22 16:34 ` Andrew Lunn
2017-09-22 17:15 ` Florian Fainelli
2017-09-22 16:17 ` [PATCH net-next 4/4] net: dsa: add port enable and disable helpers Vivien Didelot
2017-09-22 16:35 ` Andrew Lunn
2017-09-22 17:16 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922191105.GF3470@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox