From: Steffen Klassert <steffen.klassert@secunet•com>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: <herbert@gondor•apana.org.au>, <davem@davemloft•net>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH 5/5] xfrm: eradicate size_t
Date: Mon, 25 Sep 2017 13:46:26 +0200 [thread overview]
Message-ID: <20170925114625.GP3149@secunet.com> (raw)
In-Reply-To: <20170921204853.GF13550@avx2>
On Thu, Sep 21, 2017 at 11:48:54PM +0300, Alexey Dobriyan wrote:
> All netlink message sizes are a) unsigned, b) can't be >= 4GB in size
> because netlink doesn't support >= 64KB messages in the first place.
>
> All those size_t across the code are a scam especially across networking
> which likes to work with small numbers like 1500 or 65536.
>
> Propagate unsignedness and flip some "int" to "unsigned int" as well.
>
> This is preparation to switching nlmsg_new() to "unsigned int".
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail•com>
All applied to ipsec-next, thanks Alexey!
prev parent reply other threads:[~2017-09-25 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 20:45 [PATCH 1/5] xfrm: make aead_len() return unsigned int Alexey Dobriyan
2017-09-21 20:46 ` [PATCH 2/5] xfrm: make xfrm_alg_len() " Alexey Dobriyan
2017-09-21 20:47 ` [PATCH 3/5] xfrm: make xfrm_alg_auth_len() " Alexey Dobriyan
2017-09-21 20:47 ` [PATCH 4/5] xfrm: make xfrm_replay_state_esn_len() " Alexey Dobriyan
2017-09-21 20:48 ` [PATCH 5/5] xfrm: eradicate size_t Alexey Dobriyan
2017-09-25 11:46 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925114625.GP3149@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox