From: "Yang, Yi" <yi.y.yang@intel•com>
To: Jiri Benc <jbenc@redhat•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"dev@openvswitch•org" <dev@openvswitch•org>,
"e@erig•me" <e@erig•me>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [PATCH net-next v10] openvswitch: enable NSH support
Date: Wed, 27 Sep 2017 08:52:19 +0800 [thread overview]
Message-ID: <20170927005218.GA97665@cran64.bj.intel.com> (raw)
In-Reply-To: <20170926164240.764a66ed@griffin>
On Tue, Sep 26, 2017 at 10:42:40PM +0800, Jiri Benc wrote:
> On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote:
> > > + return ((ret != 0) ? false : true);
> >
> > But I don't think this is a problematic line from my understanding,
>
> Why not:
>
> return ((ret != 0 == true) ? false : true) == true;
>
> ?
>
> Sigh. This is equal to:
>
> return !ret;
>
> which you should use.
Ok, got it, I'll use "return !ret;", real programming art :-), I also saw
!!(condition), personally its readability is not good, typical kernel
style :-)
prev parent reply other threads:[~2017-09-27 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 4:47 [PATCH net-next v10] openvswitch: enable NSH support Yi Yang
2017-09-26 10:50 ` Jiri Benc
[not found] ` <1506401236-5716-1-git-send-email-yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-26 11:05 ` Jiri Benc
2017-09-26 13:52 ` Yang, Yi
2017-09-26 14:42 ` Jiri Benc
2017-09-27 0:52 ` Yang, Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927005218.GA97665@cran64.bj.intel.com \
--to=yi.y.yang@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dev@openvswitch$(echo .)org \
--cc=e@erig$(echo .)me \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox