Subject: Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 27 Sep 2017 09:03:34 +0200

On Mon, 25 Sep 2017 02:25:52 +0200
Daniel Borkmann <[email-masked]> wrote:

> Looks like a couple of updates missed to get carried into tools/include/uapi/,
> so copy the bpf.h header as usual to pull in latest updates.
> 
> Signed-off-by: Daniel Borkmann <[email-masked]>
> Acked-by: Alexei Starovoitov <[email-masked]>
> Acked-by: John Fastabend <[email-masked]>
> ---
>  tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------
>  1 file changed, 32 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 461811e..e43491a 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -143,12 +143,6 @@ enum bpf_attach_type {
>  
>  #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE
>  
> -enum bpf_sockmap_flags {
> -	BPF_SOCKMAP_UNSPEC,
> -	BPF_SOCKMAP_STRPARSER,
> -	__MAX_BPF_SOCKMAP_FLAG
> -};
> -

Why does "bpf_sockmap_flags" gets removed?

It got added in: commit 69e8cc134bcb ("bpf: sockmap sample program").
But I cannot find any users of these flags, so I guess it is okay.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer