Subject: Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

From: Ido Schimmel <[email-masked]>
Date: Wed, 4 Oct 2017 15:31:17 +0300

On Wed, Oct 04, 2017 at 01:52:20PM +0900, Toshiaki Makita wrote:
> On 2017/10/04 1:42, Ido Schimmel wrote:
> > The driver can make sure it's able to handle the configured
> > `vlan_filtering` state during port enslavement to the bridge and also
> > forbid it from being toggled once it's enslaved.
> 
> That is a simple solution.
> One concern is backward compatibility. I wonder if we can prohibit
> toggling for some driver which currently allows it.

IMO, it's invalid to continue to allow this when we know the requested
behavior isn't honored and packets are forwarded incorrectly.