Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

From: Bjorn Andersson <[email-masked]>
Date: Tue, 10 Oct 2017 23:54:45 -0700

On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:

> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
> 

Thanks, not sure how I could miss that one. Kalle can you please include
this in a v4.14-rc pull request?

:

Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")

> Signed-off-by: Jia-Ju Bai <[email-masked]>

Acked-by: Bjorn Andersson <[email-masked]>

Regards,
Bjorn

> ---
>  drivers/net/wireless/ath/wcn36xx/main.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 35bd50b..b83f01d 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
>  			if (!sta) {
>  				wcn36xx_err("sta %pM is not found\n",
>  					      bss_conf->bssid);
> -				rcu_read_unlock();
>  				goto out;
>  			}
>  			sta_priv = wcn36xx_sta_to_priv(sta);
> -- 
> 1.7.9.5
> 
> 
> 
> _______________________________________________
> wcn36xx mailing list
> [email-masked]
> http://lists.infradead.org/mailman/listinfo/wcn36xx