Subject: Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

From: Kalle Valo <[email-masked]>
Date: Fri, 27 Oct 2017 07:51:09 +0000 (UTC)

Arnd Bergmann <[email-masked]> wrote:

> The stack consumption in this driver is still relatively high, with one
> remaining warning if the warning level is lowered to 1536 bytes:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: the frame size of 1880 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
> 
> The affected function is actually a collection of three separate implementations,
> and each of them is fairly large by itself. Splitting them up is done easily
> and improves readability at the same time.
> 
> I'm leaving the original indentation to make the review easier.
> 
> Acked-by: Arend van Spriel <[email-masked]>
> Signed-off-by: Arnd Bergmann <[email-masked]>

2 patches applied to wireless-drivers-next.git, thanks.

0425f079590c brcmsmac: split up wlc_phy_workarounds_nphy
ad1987d67392 brcmsmac: reindent split functions

-- 
https://patchwork.kernel.org/patch/9967141/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches