From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, opendmb@gmail•com,
Marc Gonzalez <marc_gonzalez@sigmadesigns•com>,
slash.tmp@free•fr, david.daney@cavium•com,
geert+renesas@glider•be
Subject: Re: [RFC net-next 0/4] net: phy: PHY_HALTED, the return of the state
Date: Fri, 27 Oct 2017 13:35:18 +0200 [thread overview]
Message-ID: <20171027113518.GD17415@lunn.ch> (raw)
In-Reply-To: <20171025232124.14120-1-f.fainelli@gmail.com>
On Wed, Oct 25, 2017 at 04:21:20PM -0700, Florian Fainelli wrote:
> Hi all,
>
> This patch series tries to address the shortcomings of the previously and then
> quickly reverted commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy:
> Correctly process PHY_HALTED in phy_stop_machine()")
>
> This time, the empire returns and strikes back with a few additional changes:
>
> - catch phy_disconnect() calls without prior phy_stop() and warn when that
> happens since that means a driver is not behaving properly. This is AFAIR
> the case in which David Daney ran into
>
> - what David also was running into is that when the PHY state machine was
> already in PHY_HALTED, its synchronous call in phy_disconnect() would make
> us re-schedule ourselves at the end. This is unnecessary, and we now take
> care of that
>
> - finally, Geert experienced bus errors on smsc911x for a number of reasons,
> but the primary one is that the driver does not do any management of the
> PHY state machine during suspend/resume. The last patch corrects that, and
> also suggests that the driver should be fixed to properly support Wake-on-LAN
> configuration to possibly suspend the PHY.
>
> David, Marc and Geert, I would appreciate if you could give this patch series
> a spin on your respective HW and confirm that the desired functionality is
> achieved.
Hi Florian
I quickly look through these patches and they all seem
sensible. Feedback from the listed people would however be good.
Andrew
next prev parent reply other threads:[~2017-10-27 11:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 23:21 [RFC net-next 0/4] net: phy: PHY_HALTED, the return of the state Florian Fainelli
2017-10-25 23:21 ` [RFC net-next 1/4] net: phy: Export phy_stop_machine() Florian Fainelli
2017-10-30 13:44 ` Geert Uytterhoeven
2017-10-25 23:21 ` [RFC net-next 2/4] net: smsc911x: Properly manage PHY during suspend/resume Florian Fainelli
2017-10-30 13:45 ` Geert Uytterhoeven
2017-10-25 23:21 ` [RFC net-next 3/4] net: phy: Force PHY_HALTED during phy_disconnect() Florian Fainelli
2017-10-25 23:21 ` [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine() Florian Fainelli
2017-10-30 13:56 ` Geert Uytterhoeven
2017-10-30 16:09 ` Florian Fainelli
2017-10-31 15:26 ` Geert Uytterhoeven
2017-10-31 16:33 ` Florian Fainelli
2017-11-06 15:50 ` Geert Uytterhoeven
2017-11-27 4:05 ` Florian Fainelli
2017-11-27 7:48 ` Geert Uytterhoeven
2017-12-04 15:08 ` Marc Gonzalez
2017-10-27 11:35 ` Andrew Lunn [this message]
2017-10-30 15:44 ` [RFC net-next 0/4] net: phy: PHY_HALTED, the return of the state Marc Gonzalez
2017-10-30 16:27 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027113518.GD17415@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=david.daney@cavium$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=marc_gonzalez@sigmadesigns$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opendmb@gmail$(echo .)com \
--cc=slash.tmp@free$(echo .)fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox