From: Simon Guinot <simon.guinot@sequanux•org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
Cc: "Sven Müller" <musv@gmx•de>,
"Andreas Tobler" <andreas.tobler@cloudguard•ch>,
"Grégory Clement" <gregory.clement@free-electrons•com>,
"Antoine Ténart" <antoine.tenart@free-electrons•com>,
netdev@vger•kernel.org, "Marcin Wojtas" <mw@semihalf•com>
Subject: Re: Problems with mvneta
Date: Tue, 31 Oct 2017 18:09:38 +0100 [thread overview]
Message-ID: <20171031170938.GC18407@kw.sim.vm.gnt> (raw)
In-Reply-To: <20171031152740.72ab6829@windsurf>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
On Tue, Oct 31, 2017 at 03:27:40PM +0100, Thomas Petazzoni wrote:
> Hello,
Hi Thomas,
>
> Let's add Simon Guinot in the loop.
>
> On Tue, 31 Oct 2017 15:23:22 +0100, Sven Müller wrote:
> > After quite a long time of trying to reproduce the issue without any success I got 3 network crashes today. And all errors occurred with a kernel including the patch:
> >
> > 2a90f7e1d5d04e4f1060268e0b55a2c702bbd67a
> >
> > At least according to Andreas' and my problems we can exclude the 6ad2 patch as the source of the errors.
>
> Simon, 2a90f7e1d5d04e4f1060268e0b55a2c702bbd67a is your commit, adding
> xmit_more support, and a number of people are reporting stability
> issues with this patch applied.
I wrote an earlier version of this patch. But I think this commit has
been modified by the submitter Marcin Wojtas because I don't remember
anything about the maximum number of descriptors allowed to be flush.
>
> Do you think you will have some time to look into this ?
No I don't have time to look into that.
But after a quick look, I wonder what is happening if
"txq->pending + frags > MVNETA_TXQ_DEC_SENT_MASK" ? Because IIUC
mvneta_txq_pend_desc_add() is called anyway. And according to the
comment inside the function, it assumes there is less than 255
descriptors to send... It looks suspect.
Simon
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-10-31 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171018223425.42ce7a74@gmx.de>
2017-10-18 20:55 ` Problems with mvneta Thomas Petazzoni
2017-10-19 22:25 ` Sven Müller
2017-10-20 7:09 ` Thomas Petazzoni
2017-10-23 6:29 ` Andreas Tobler
2017-10-23 9:30 ` Sven Müller
2017-10-31 14:23 ` Sven Müller
2017-10-31 14:27 ` Thomas Petazzoni
2017-10-31 17:09 ` Simon Guinot [this message]
2017-10-31 20:23 ` Thomas Petazzoni
2017-11-01 8:10 ` Marcin Wojtas
2017-11-08 16:58 ` [PATCH] net: mvneta: fix handling of the Tx descriptor counter Simon Guinot
2017-11-08 17:03 ` David Laight
2017-11-08 17:17 ` Simon Guinot
2017-11-09 19:19 ` Andreas Tobler
2017-11-11 9:45 ` David Miller
2017-11-13 14:51 ` Simon Guinot
2017-11-13 14:54 ` David Miller
2017-11-13 15:36 ` Simon Guinot
2017-11-20 14:58 ` David Laight
2017-11-13 15:27 ` [PATCH v2] " Simon Guinot
2017-11-14 12:53 ` David Miller
2017-11-10 10:22 ` [PATCH] " Sven Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031170938.GC18407@kw.sim.vm.gnt \
--to=simon.guinot@sequanux$(echo .)org \
--cc=andreas.tobler@cloudguard$(echo .)ch \
--cc=antoine.tenart@free-electrons$(echo .)com \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=musv@gmx$(echo .)de \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox