From: "Tobin C. Harding" <me@tobin•cc>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: Network Development <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>,
"kernel-hardening@lists•openwall.com"
<kernel-hardening@lists•openwall.com>,
"Jason A. Donenfeld" <Jason@zx2c4•com>,
Theodore Ts'o <tytso@mit•edu>, Kees Cook <keescook@chromium•org>,
Paolo Bonzini <pbonzini@redhat•com>,
Tycho Andersen <tycho@docker•com>,
"Roberts, William C" <william.c.roberts@intel•com>,
Tejun Heo <tj@kernel•org>,
Jordan Glover <Golden_Miller83@protonmail•ch>,
Greg KH <gregkh@linuxfoundation•org>,
Petr Mladek <pmladek@suse•com>, Joe Perches <joe@perches•com>,
Ian Campbell <ijc@hellion•org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <wilal.deacon@arm•com>,
Steven Rostedt <rosted
Subject: Re: [PATCH v3] scripts: add leaking_addresses.pl
Date: Tue, 7 Nov 2017 08:15:40 +1100 [thread overview]
Message-ID: <20171106211540.GT18478@eros> (raw)
In-Reply-To: <CA+55aFw6A8Ta=yMGKiOdcMMV16-PuP9GZmia4yA_5zLdoJnFUQ@mail.gmail.com>
On Mon, Nov 06, 2017 at 09:41:09AM -0800, Linus Torvalds wrote:
> On Mon, Nov 6, 2017 at 9:27 AM, Linus Torvalds
> <torvalds@linux-foundation•org> wrote:
> >
> > Lovely. This is great. It shows just how much totally pointless stuff
> > we leak, and to normal users that really shouldn't need it.
>
> Side note: it would be good to have some summary view, and perhaps
> some way to limit duplicates.
This has been bothering me also.
> I ended up running this command line from hell to summarize the
> different sources:
>
> perl leaking_addresses.pl |
> cut -d: -f1 |
> sed 's:/[0-9]*/:/X/:g' |
> sed 's:/module/[^/]*/:/module/X/:g' |
> sort | uniq | less -S
>
> and maybe that kind of duplicate culling could be part of the script
> itself if you pass it some summary line.
>
> In particular, if would be nice to have a summary report that
>
> - only shows the first address for a particular source
>
> - have some logic to collapse repeated entries of "same file, just
> different instance"
>
> my sed-invocations there are obviously very ad-hoc, I'm not actually
> advocating that crap, it's only meant as hacky example of what I'm
> talking about. Something smarter would be much better.
>
> Because right now if some developer runs it, they might miss some case
> that they should care about, simply because it's hidden among all the
> thousands of essentially duplicate cases.
Awesome. I'm on it. thanks.
So, cull duplicates by default, add summary report to end of output, add
'--raw' option to dump all the lines (the current output).
thanks,
Tobin.
next prev parent reply other threads:[~2017-11-06 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1509945567-11801-1-git-send-email-me@tobin.cc>
2017-11-06 17:27 ` [PATCH v3] scripts: add leaking_addresses.pl Linus Torvalds
2017-11-06 17:41 ` Linus Torvalds
2017-11-06 21:15 ` Tobin C. Harding [this message]
2017-11-06 18:25 ` [kernel-hardening] " Pavel Vasilyev
2017-11-06 21:03 ` Tobin C. Harding
2017-11-07 21:22 ` Kees Cook
2017-11-07 21:44 ` Linus Torvalds
2017-11-07 22:08 ` Kees Cook
2017-11-07 22:44 ` Steven Rostedt
2017-11-08 8:20 ` Peter Zijlstra
2017-11-08 3:06 ` Tobin C. Harding
2017-11-08 2:05 ` Tobin C. Harding
2017-11-08 4:18 ` Tobin C. Harding
2017-11-08 3:24 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106211540.GT18478@eros \
--to=me@tobin$(echo .)cc \
--cc=Golden_Miller83@protonmail$(echo .)ch \
--cc=Jason@zx2c4$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=ijc@hellion$(echo .)org.uk \
--cc=joe@perches$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pbonzini@redhat$(echo .)com \
--cc=pmladek@suse$(echo .)com \
--cc=sergey.senozhatsky@gmail$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=tycho@docker$(echo .)com \
--cc=tytso@mit$(echo .)edu \
--cc=wilal.deacon@arm$(echo .)com \
--cc=william.c.roberts@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox