From: Kalle Valo <kvalo@codeaurora•org>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Stanislaw Gruszka <sgruszka@redhat•com>,
Helmut Schaa <helmut.schaa@googlemail•com>,
Arnd Bergmann <arnd@arndb•de>,
Johannes Berg <johannes.berg@intel•com>,
"David S. Miller" <davem@davemloft•net>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: rt2x00: use monotonic timestamps for frame dump
Date: Fri, 10 Nov 2017 02:34:39 +0000 (UTC) [thread overview]
Message-ID: <20171110023439.DF069607EF@smtp.codeaurora.org> (raw)
In-Reply-To: <20171106140412.1532617-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb•de> wrote:
> rt2x00 uses the deprecated do_gettimeofday() function to get a timestamp
> for its debugfs "dump" file interface.
>
> The timestamp is using an unsigned 32-bit value, so we could make it
> work until 2106 by using ktime_get_real_ts64(), but it seems better to
> use monotonic times, as we normally want for timestamps.
>
> Since this is an interface change, I'm incrementing the
> DUMP_HEADER_VERSION number, so user space can figure out whether the
> timestamps are monotonic or not. Most likely the tools won't care either
> way.
>
> Generally speaking, ABI version numbers and in particular changing them
> is a bad idea. However since this is in debugfs, we don't put any
> API stability rules on the interface according to
> Documentation/filesystems/debugfs.txt, and we can take the easy way
> out here; anyone using the frame dump feature can probably work out
> the differences here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Patch applied to wireless-drivers-next.git, thanks.
f87eba996bac rt2x00: use monotonic timestamps for frame dump
--
https://patchwork.kernel.org/patch/10043531/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-11-10 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:03 [PATCH] rt2x00: use monotonic timestamps for frame dump Arnd Bergmann
2017-11-10 2:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110023439.DF069607EF@smtp.codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=helmut.schaa@googlemail$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sgruszka@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox