Subject: Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

From: Jiri Pirko <[email-masked]>
Date: Mon, 13 Nov 2017 07:25:38 +0100

Mon, Nov 13, 2017 at 03:14:18AM CET, [email-masked] wrote:
>On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <[email-masked]>
>> 
>> In order to remove tp->q usage in cls_bpf, the offload->netdev check
>> needs to be moved to individual drivers as only they will have access
>> to appropriate struct net_device.
>> 
>> Signed-off-by: Jiri Pirko <[email-masked]>
>
>This seems not entirely correct and it adds unnecessary code.  I think

What is not correct?

>the XDP and cls_bpf handling could be unified, making way for binding
>the same program to multiple ports of the same device.  Would you mind
>waiting a day for me to send corrections to BPF offload?

Well I'm trying to get this in before net-next closes...