Subject: Re: [PATCH net-next] dt-bindings: net: dsa: Document additional Microchip KSZ family switches

From: Andrew Lunn <[email-masked]>
Date: Fri, 17 Nov 2017 04:57:05 +0100

> +		ksz9477: ksz9477@0 {
> +			compatible = "microchip,ksz9477";
> +			reg = <0>;
>  
> -                                                             spi-max-frequency = <44000000>;
> -                                                             spi-cpha;
> -                                                             spi-cpol;
> +			spi-max-frequency = <44000000>;
> +			spi-cpha;
> +			spi-cpol;

...

> +
> +		};
> +		ksz8794: ksz8794@0 {
> +			compatible = "microchip,ksz8794";
> +			reg = <0>;
> +
> +			spi-max-frequency = <30000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
> +			};

...

> +		};
> +		ksz8864: ksz8864@0 {
> +			compatible = "microchip,ksz8864";
> +			reg = <0>;
> +
> +			spi-max-frequency = <12000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
...
> +		};
> +	};

Hi Tristram

Nitpick. These all appear to be on the same SPI bus. So they should
have different reg values.

Also, the label is supposed to be generic, not specific. So switch0:
ksz9477@0, switch1: ksz8794@1, etc.

	   Andrew