Subject: Re: [PATCH iproute2/net-next v3]tc: B.W limits can now be specified in %.

From: Stephen Hemminger <[email-masked]>
Date: Fri, 17 Nov 2017 13:12:58 -0800

On Sat, 18 Nov 2017 02:13:38 +0530
Nishanth Devarajan <[email-masked]> wrote:

> diff --git a/tc/tc_util.h b/tc/tc_util.h
> index 583a21a..7b7420a 100644
> --- a/tc/tc_util.h
> +++ b/tc/tc_util.h
> @@ -24,14 +24,14 @@ struct qdisc_util {
>  	struct  qdisc_util *next;
>  	const char *id;
>  	int (*parse_qopt)(struct qdisc_util *qu, int argc,
> -			  char **argv, struct nlmsghdr *n);
> +			  char **argv, struct nlmsghdr *n, char *dev);

One more nit...
Since parsing queue options should not modify the device name, that should
be const char *.