Subject: Re: [PATCH iproute2 1/1] actions: Add support for user cookies

From: Stephen Hemminger <[email-masked]>
Date: Thu, 23 Nov 2017 13:12:04 -0800

On Sat, 22 Apr 2017 08:36:23 -0400
Jamal Hadi Salim <[email-masked]> wrote:

> +
>  		fprintf(f, "\tAction statistics:\n");
>  		print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
> +		if (tb[TCA_ACT_COOKIE]) {
> +			int strsz = RTA_PAYLOAD(tb[TCA_ACT_COOKIE]);
> +			char b1[strsz+1];
> +
> +			fprintf(f, "\n\tcookie len %d %s ", strsz,
> +				hexstring_n2a(RTA_DATA(tb[TCA_ACT_COOKIE]),
> +					      strsz, b1, sizeof(b1)))

I don't think you need to print len here. Already know that by the output of 
hexstring. Since payload length is in bytes and hex takes two characters per byte
then the buffer needs to be bigger (like TCPCOOKIE_MAX_SIZE * 2 + 1)